search

fzyzcjy / dart_interactive

REPL (interactive shell) for Dart, supporting 3rd party packages, hot reload, and full grammar
https://github.com/fzyzcjy/dart_interactive
MIT License
147 stars 12 forks source link

Update README.md with limitations in Windows #94

Closed Chematronix closed 6 days ago

welcome[bot] commented 1 week ago

Hi! Thanks for opening this pull request! :smile:

fzyzcjy commented 1 week ago

Hmm, I wonder why Windows has those problems and whether we can avoid them? Theoretically speaking, this package does not use any *nix-specific api at all!

Chematronix commented 1 week ago

Hmm, I wonder why Windows has those problems and whether we can avoid them? Theoretically speaking, this package does not use any *nix-specific api at all!

It's a dart:io bug (dart-lang/sdk#48329) which impacts cli_repl. I'ts been mentioned before #81 #88 (and I see an unfinished PR at #61). Fortunately it's easy to install WSL.

I would worry more about "Hot reload failed" on syntax/type errors, which completely breaks the REPL in all platforms and wipes all your progress. At least that's what happens if I do something like print() or 1+'a'.

fzyzcjy commented 1 week ago

I see. Then maybe we should explain it is dart:io bug. No worries just leave this pr as-is and I will update it.

I would worry more about "Hot reload failed" on syntax/type errors, which completely breaks the REPL in all platforms and wipes all your progress. At least that's what happens if I do something like print() or 1+'a'.

I do not have windows at hand, so I wonder whether you mean "Hot reload failed" is also caused by this dart:io bug? Or by something else

Chematronix commented 1 week ago

I do not have windows at hand, so I wonder whether you mean "Hot reload failed" is also caused by this dart:io bug? Or by something else

It happens with some syntax or type errors, in both Windows and WSL Linux, so I'd assume it breaks other platforms/OSes as well, if not all of them (that's what I meant to indicate in the Readme changes). It's unrelated to the dart:io keyboard issues. It's pretty aggravating. This doesn't happen in MacOS?

image

fzyzcjy commented 1 week ago

Oh I see. Btw it would be great if we fix this, and feel free to PR for this!

fzyzcjy commented 1 week ago

(I will merge a bit later since will need to do a bit of modifications after merging)

welcome[bot] commented 6 days ago

Hi! Congrats on merging your first pull request! :tada:

fzyzcjy commented 6 days ago

@all-contributors please add @Chematronix for code

allcontributors[bot] commented 6 days ago

@fzyzcjy

I've put up a pull request to add @Chematronix! :tada:

fzyzcjy commented 6 days ago

@all-contributors please add @Chematronix for doc

allcontributors[bot] commented 6 days ago

@fzyzcjy

I've put up a pull request to add @Chematronix! :tada: