Abstract async runtimes

fzyzcjy / flutter_rust_bridge

Flutter/Dart <-> Rust binding generator, feature-rich, but seamless and simple.

https://fzyzcjy.github.io/flutter_rust_bridge/

MIT License

3.64k stars 256 forks source link

Abstract async runtimes #1848

Open malivix opened 2 months ago

malivix commented 2 months ago

Changes

Close #1846 (EDITed by @fzyzcjy to use "Close" to make github auto trigger correlation)

Checklist

[X] An issue to be fixed by this PR is listed above.
[ ] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
[X] ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
[ ] If this PR adds/changes features, documentations (in the ./website folder) are updated.
[ ] CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

./frb_internal --help shows utilities for development.
If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

welcome[bot] commented 2 months ago

Hi! Thanks for opening this pull request! :smile:

malivix commented 2 months ago

@fzyzcjy can you check you are happy with approach then I need to fix some stuff about cargo.lock also how user can spawn or spawn_local ...

fzyzcjy commented 2 months ago

@malivix Looked at the code very briefly and the rough approach seems OK to me!

codecov[bot] commented 2 months ago

Files	Patch %	Lines
frb_rust/src/rust_async/io/tokio.rs	68.88%	14 Missing :warning:

```diff @@ Coverage Diff @@ ## master #1848 +/- ## ========================================== - Coverage 99.27% 97.69% -1.58% ========================================== Files 359 359 Lines 15127 15119 -8 ========================================== - Hits 15017 14771 -246 - Misses 110 348 +238 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

malivix commented 1 month ago

Good job! Mainly some nits

I am on travel will finalize it soon

fzyzcjy commented 1 month ago

I am on travel will finalize it soon

No worries, take your time and have a good vacation!

debanjanbasu commented 6 days ago

@malivix - Is this going to get some love? 🥰, have been waiting for it for some time... Is there anything I can be of help with?

malivix commented 6 days ago