fzyzcjy / flutter_rust_bridge

Flutter/Dart <-> Rust binding generator, feature-rich, but seamless and simple.
https://fzyzcjy.github.io/flutter_rust_bridge/
MIT License
4.29k stars 301 forks source link

Use portable-atomic in frb_rust #2323

Closed kyrias closed 1 month ago

kyrias commented 1 month ago

Not all targets supports AtomicU64 which currently makes it difficult to share the same crate between multiple targets. portable-atomic uses the std version of the type if one exists and otherwise emulates a fallback using atomic CAS operations.

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

Remark for PR creator

welcome[bot] commented 1 month ago

Hi! Thanks for opening this pull request! :smile:

kyrias commented 1 month ago

I'm so confused here. I push something and some CI jobs fail. I run those locally and commit and push the pubspec.lock changes it complained about which then causes another CI job to fail because it wants the pubspec.lock file to be unchanged?

fzyzcjy commented 1 month ago

CI uses a fixed version of Flutter https://github.com/fzyzcjy/flutter_rust_bridge/blob/4f5cf68f56ed56df62264227d81891744c356403/.github/workflows/ci.yaml#L14. Thus, an easy way is to fix your local Flutter to 3.22.0 and run everything. Another way is to bump everything in CI (but not sure whether this will cause a merge conflict with something similar in https://github.com/fzyzcjy/flutter_rust_bridge/pull/2320#issuecomment-2378343810)

fzyzcjy commented 1 month ago

@all-contributors please add @kyrias for code

allcontributors[bot] commented 1 month ago

@fzyzcjy

I've put up a pull request to add @kyrias! :tada:

welcome[bot] commented 1 month ago

Hi! Congrats on merging your first pull request! :tada: