Update troubleshooting.md

fzyzcjy / flutter_rust_bridge

Flutter/Dart <-> Rust binding generator, feature-rich, but seamless and simple.

https://fzyzcjy.github.io/flutter_rust_bridge/

MIT License

4.29k stars 301 forks source link

Closed bubnov closed 1 month ago

bubnov commented 1 month ago

Mention the fix for the issue when Cargokit fails to build for macos target.

Added new section to the troubleshooting.md file.

[x] An issue to be fixed by this PR is listed above.
[ ] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
[ ] ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
[x] If this PR adds/changes features, documentations (in the ./website folder) are updated.
[ ] CI is passing. Please refer to this page to see how to solve a failed CI.

./frb_internal --help shows utilities for development.
If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

welcome[bot] commented 1 month ago

Hi! Thanks for opening this pull request! :smile:

fzyzcjy commented 1 month ago

Good job!

Btw do you have interest in bumping the versions to make CI green? (just follow the git diff like https://github.com/fzyzcjy/flutter_rust_bridge/actions/runs/11345086811/job/31551204489?pr=2350 and modify what it disagrees) Alternatively I will do that simple bump.

bubnov commented 1 month ago

I'm not quite sure what to do here to be honest. Also it is strange that a simple doc update requires the version bump. Source code left intact.

I think I will skip for now. It is much easier for you to do that.

Also, it seems like this is a good candidate for automatisation (e.g. a bash script for the version bump).

fzyzcjy commented 1 month ago

Sure, no problem!

Also it is strange that a simple doc update requires the version bump

It is because of time: the upstream package updates once in a while.

a bash script for the version bump

Yes there's one. I said the manual way because I guess you may not have all dependencies installed.

welcome[bot] commented 1 month ago

Hi! Congrats on merging your first pull request! :tada:

fzyzcjy commented 1 month ago

@all-contributors please add @bubnov for doc

allcontributors[bot] commented 1 month ago

@fzyzcjy

I've put up a pull request to add @bubnov! :tada: