fzyzcjy / flutter_rust_bridge

Flutter/Dart <-> Rust binding generator, feature-rich, but seamless and simple.
https://fzyzcjy.github.io/flutter_rust_bridge/
MIT License
4.23k stars 291 forks source link

[Bug] StreamSink starving memory #2373

Open thunderstorm010 opened 4 hours ago

thunderstorm010 commented 4 hours ago

Hi. I'm trying to stream video frames (in this example Vec) from Rust to Flutter. But frb seems to eat more and more RAM growing exponentially.

Here is my code:

pub fn stream_video(stream_sink: StreamSink<Vec<u8>>, pipeline: String) -> anyhow::Result<()> {
    gstreamer::init().unwrap();
    let element = gstreamer::parse::launch(&pipeline)?;
    let bin = element
        .downcast::<Bin>()
        .map_err(|_| anyhow::anyhow!("Failed to downcast initial element to bin"))?;
    let sink_element = bin.by_name("video-sink").ok_or(anyhow::anyhow!("Failed to find appsink named video-sink. The pipeline should always end with an appsink named video-sink"))?;
    let sink = sink_element.downcast::<gstreamer_app::AppSink>().map_err(|_| anyhow::anyhow!("Failed to map sink element to appsink. The pipeline should always end with an appsink"))?;
    bin.set_state(gstreamer::State::Playing).unwrap();
    std::thread::spawn(move || {
        loop {
            let sample = sink.pull_sample().unwrap();
            let buf = sample.buffer().unwrap().map_readable().unwrap().to_vec();
            stream_sink.add(buf).unwrap();
        }   
    });
    Ok(())
}

Notes: 1) Removing the line with stream_sink.add results in constant memory use (aka no problem.) (I think this means the problem is not with Gstreamer) 2) Even when I remove the dart side code handling the stream (inside the Stream.listen function), memory use continues to grow. 3) If further information is needed, just write a comment and I will answer asap.

Thanks for everything

welcome[bot] commented 4 hours ago

Hi! Thanks for opening your first issue here! :smile:

fzyzcjy commented 1 hour ago

Hi, could you please make a minimal reproducible sample? For example, maybe

pub fn f(sink: StreamSink<Vec<u8>>) {
  loop {
    sink.add(vec![0; 1000000]);
    sleep(100ms);
  }
}

And to debug, also try to do manually trigger a (full) GC on Dart side, and see whether memory is better.

And try dart's devtool's memory part, to see what is eating a lot of memory, and why they are alive instead of GCed.

fzyzcjy commented 1 hour ago

Btw, if you want to show videos, then I guess it is great to avoid such rust-to-dart transfer, because after you transfer the bytes to Dart, indeed dart has to again transfer to its engine and display, which is quite long and slow.

One possible way may be, use https://github.com/irondash/irondash/tree/main/texture. Then the rust gstreamer frames can directly be displayed to screen, and the rest of the app can be written in Flutter.

Possibly related: https://github.com/fzyzcjy/flutter_rust_bridge/issues/1776