search

fzzyhmstrs / EMI_loot

12 stars 10 forks source link

use the `emi_loot` namespace instead of the `emi` namespace in recipe id #47

Closed walksanatora closed 1 week ago

walksanatora commented 8 months ago

another nitpick since I am currently dumping recipes for future EMC usage. please don't use the emi namespace. it makes it a lot harder to notice which recipes are yours. as inorder to check if it is your recipe I have to check for emi namespace and then emi_loot as the "root" folder of the path instead of emi:emi_loot/block_drops/minecraft/blocks/oak_leaves it could instead be emi_loot:block_drops/minecraft/blocks/oak_leaves this also makes more sense as the recipe category is emi_loot:block_drops

fzzyhmstrs commented 8 months ago

Those recipe ids are synthetic and were made when Emi's recommendation was to use the emi namespace for them. I'll put a note to update them now that her recommendation has changed

walksanatora commented 8 months ago

idk if the reccomendation has changed. It is just that it doesen't feel quite right to put it under emi namespaces. but I can re-check if it is still correct (and afterall I can still filter by recipe category)

walksanatora commented 8 months ago

image confirmed by emi. it was propper form. but is now outdated

fzzyhmstrs commented 1 week ago

this has been fixed for a while, forgot to close.