search

g-adopt / g-adopt

Repository for the development of the Geoscientific ADjoint Optimization PlaTform (G-ADOPT).
https://gadopt.org/
MIT License
19 stars 0 forks source link

DG Energy Solve with SU_advection = True #62

Closed drhodrid closed 6 months ago

drhodrid commented 8 months ago

I recently (accidentally) ran a case with a DG approach for the energy solve, but forgot to remove the su_advection = True flag. I'm unsure what this would've done (!), but it's probably wise to add some sort of options check to ensure that others don't make the same mistake. Thoughts?

w3168 commented 8 months ago

Ah yeah I probably should put an assert in to make sure that it's only on the right function spaces

drhodrid commented 8 months ago

I mean it was also a silly mistake on my part, but probably good to get an assert in, just to be safe!!

Professor (Computational & Observational Geodynamics) Associate Director Research & Engagement Research School of Earth Sciences, The Australian National University, Mills Road, Acton, Canberra, ACT, 2601, Australia

T: +61 (0)2 6125 3643 E: @.*** W: https://earthsciences.anu.edu.au/people/academics/professor-rhodri-davies CRICOS Provider No. 00120C

On 8 Apr 2024, at 10:00 AM, Will Scott @.***> wrote:

Ah yeah I probably should put an assert in to make sure that it's only on the right function spaces

— Reply to this email directly, view it on GitHubhttps://github.com/g-adopt/g-adopt/issues/62#issuecomment-2041652915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB25UKSM4IZ5VRADF4ELRUDY4HMZDAVCNFSM6AAAAABFWN4LMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGY2TEOJRGU. You are receiving this because you authored the thread.Message ID: @.***>