search

g-andrade / locus

MMDB reader for geolocation and ASN lookup of IP addresses
https://hexdocs.pm/locus/
MIT License
109 stars 14 forks source link

rebar3 warning in elixir projects #16

Closed sneako closed 3 years ago

sneako commented 3 years ago

First off, thanks for the great library! I have tried out several BEAM geoip libraries, and locus is by far my favorite and the most performant one I have found.

I am using locus in an Elixir project, and am constantly getting the nice big warning:

        !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
        !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
        *********************************************************************

        [locus] You're **strongly** incentivized to use `rebar3`.
        Compatibility with rebar 2 is unmaintained and will be removed in the near future.

        *********************************************************************
        !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
        !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

from both locus and tls_certificate_check.

You probably do not use Elixir yourself, but I was hoping to begin a discussion on how we could modify the check so that locus can be used within Elixir projects without emitting these warnings.

g-andrade commented 3 years ago

Oh! It never occurred to me that mix could be detected as being rebar 2... but it makes sense, given the way that detection is performed.

Perhaps the check could be expanded into looking for mix's presence - I'll need to look for appropriate module and function names (which will likely need to be prefixed with 'Elixir.', assuming they'll be named after Elixir-style upper case atoms.)

g-andrade commented 3 years ago

Fixed under e7bfbcb and released as 1.12.1.

Closing this; please re-open if for some reason the fix doesn't work. Cheers!

sneako commented 3 years ago

It works, thanks!