search

g-andrade / locus

MMDB reader for geolocation and ASN lookup of IP addresses
https://hexdocs.pm/locus/
MIT License
109 stars 14 forks source link

`rebar3 ct` fails; `make ci_test` doesn't #17

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

I'd expect rebar3 ct to not fail, but that's probably not your expectation. Will reply will clarify this 😄.

g-andrade commented 3 years ago

The errors are caused by an unwarranted execution of the "remote HTTP tests"[*] group, which perform various checks of the ability to load databases directly from MaxMind.

The execution of that particular test group is triggered depending on two conditions: 1) the currently checked out commit is tagged (so that we won't run these network-expensive test cases during everyday development) 2) the license key is defined through an environment variable (MAXMIND_LICENSE_KEY)

Condition 2) is erroneously evaluating as true in your case; this is due to a bad check of whether said environment variable is defined. This issue has likely been present since 1.9.0-beta (when license key awareness was introduced.)

The fix is easy enough.

[*]: In addition to "local HTTP tests", in which a local web server serves the database files.

g-andrade commented 3 years ago

As for the reason why make ci_test works: the "remote HTTP tests" group has been explicitly disabled for CI stuff for quite some time, as network access is not very reliable and the tests would often fail because of this.

g-andrade commented 3 years ago

Fixed in 42cdbda and released under 1.2.2.