search

g-battaglia / kerykeion

Data driven Astrology 💫
Kerykeion is a python library for astrology. It can generate SVG charts and extract all data about a birthchart, a synastry chart and a transit chart.
https://kerykeion.net
GNU Affero General Public License v3.0
297 stars 103 forks source link

`LunarPhaseModel` `degrees_between_s_m` attribute is always cast to int #99

Closed jackklika closed 8 months ago

jackklika commented 8 months ago

This is due to the left-to-right presidence of Union[int, float] here:

# kerykeion/kr_types/kr_models.py
class LunarPhaseModel(BaseModel):
    degrees_between_s_m: Union[int, float]
    moon_phase: int
    sun_phase: int
    moon_emoji: LunarPhaseEmoji

This is fixed in PR #98

g-battaglia commented 8 months ago

Merged, released in v 4.3.0