search

g-cqd / aemi-wp

Aemi WordPress theme
https://wordpress.org/themes/aemi/
GNU General Public License v3.0
12 stars 1 forks source link

Footer Widget Area Not Responding to Column Setting #12

Closed keempoo closed 3 years ago

keempoo commented 3 years ago

Describe the bug In Customizing> Aemi> Widgets

Changing Footer Widget Area Column Layout (Choose maximum number of column for footer widget area.)

Stays at the defaulted 2-Column

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Customizing> Aemi> Widgets> Footer Widget Area Column Layout, Choose maximum number of column for footer widget area.'
  2. Click on 'One Column'
  3. Publish
  4. See error

Expected behavior Footer widgets to be listed as one column.

Screenshots If I used the Inspector and change the default to "one-column", it appears correctly, however I do not have the savvy to fix it permanently.

Default in Inspector is "two-columns" image

Works if you change the value to "one-columns" image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Sorry it's me again. I love the theme! xoxo

g-cqd commented 3 years ago

Hi @keempoo ,

I'm really glad to hear again from you, it shows Aemi theme gets some interest and I love that. I'm also sorry you encountered a bug and moreover I'm sorry to tell you I could not reproduce it.

I get a development version of Aemi theme on https://dev.aemi.dev/ website. I turned to One then to Two then back to One column layout and I never encountered such an issue.

Please, can you tell me what version of Aemi Theme you are using ?

I have some dumb recommendations too : clean browser cache (you surely already did that) and clean cache created by any cache plugin on your WordPress website (you surely did it too). I'm waiting for more informations from you to investigate further.

Also, if you like Aemi theme, please feel free to leave a tiny (or complete) review on official WordPress.org theme page : https://wordpress.org/support/theme/aemi/reviews

Best Regards, Guillaume

keempoo commented 3 years ago

Ok, let me back up and see what an update of the theme will do for me.

On Thu, Feb 18, 2021 at 7:30 PM Guillaume C. notifications@github.com wrote:

Hi @keempoo https://github.com/keempoo ,

I'm really glad to hear again from you, it shows Aemi theme gets some interest and I love that. I'm also sorry you encountered a bug and moreover I'm sorry to tell you I could not reproduce it.

I get a development version of Aemi theme on https://dev.aemi.dev/ website. I turned to One then to Two then back to One column layout and I never encountered such an issue.

Please, can you tell me what version of Aemi Theme you are using ?

I have some dumb recommendations too : clean browser cache (you surely already did that) and clean cache created by any cache plugin on your WordPress website (you surely did it too). I'm waiting for more informations from you to investigate further.

Also, if you like Aemi theme, please feel free to leave a tiny (or complete) review on official WordPress.org theme page : https://wordpress.org/support/theme/aemi/reviews

Best Regards, Guillaume

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aemi-dev/aemi/issues/12#issuecomment-781751043, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLGFD2HMVBEUEO57YRCPVLS7W5JPANCNFSM4XRFJIAQ .

g-cqd commented 3 years ago

I think I will mention the breaking changes in the next updates to make it lesser annoying to update 🤔.

keempoo commented 3 years ago

Hi Guillaume,

Sorry for the late reply. I did manage to update the Aemi theme, but I still can't get the footer to respond to column customization on astrosalad.com. I did have help from a friend who made some adjustments, but I can't imagine how it would affect the footer. I had him make a custom page that pulled all the links from the site https://www.astrosalad.com/links/, and had him add the category descriptions to pages. His code must not be very clean because on the update some of the styling got messed up but I can probably undo it.

If you have any inklings as to what it might be, please let me know. I looked at the dev site and can't figure it out based on that.

On Fri, Feb 19, 2021 at 3:13 PM Guillaume C. notifications@github.com wrote:

I think I will mention the breaking changes in the next updates to make it lesser annoying to update 🤔.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aemi-dev/aemi/issues/12#issuecomment-782355570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLGFDZX6WFDRHX2YFRK5ITS73IA3ANCNFSM4XRFJIAQ .

keempoo commented 3 years ago

I fixed it! Just needed to switch default width, clear cache, set it back clear cache. Not sure why clearing cache without changes didn't work.

On Mon, Mar 8, 2021 at 9:35 AM Kim Phu kim@keempoo.com wrote:

Hi Guillaume,

Sorry for the late reply. I did manage to update the Aemi theme, but I still can't get the footer to respond to column customization on astrosalad.com. I did have help from a friend who made some adjustments, but I can't imagine how it would affect the footer. I had him make a custom page that pulled all the links from the site https://www.astrosalad.com/links/, and had him add the category descriptions to pages. His code must not be very clean because on the update some of the styling got messed up but I can probably undo it.

If you have any inklings as to what it might be, please let me know. I looked at the dev site and can't figure it out based on that.

On Fri, Feb 19, 2021 at 3:13 PM Guillaume C. notifications@github.com wrote:

I think I will mention the breaking changes in the next updates to make it lesser annoying to update 🤔.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aemi-dev/aemi/issues/12#issuecomment-782355570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLGFDZX6WFDRHX2YFRK5ITS73IA3ANCNFSM4XRFJIAQ .

g-cqd commented 3 years ago

Hi @keempoo ,

Thanks for keeping me up to date with the problem. I already thought that clean cache could fix this bug as said in an earlier answer. Now, with what you said, I think I know where to look for the bug. I'll try to make the theme more reliable in next update. Do not hesitate to reach me if anything goes wrong again.

I'll close this issue now that it is fixed but I'll keep in mind to get rid of this bug.

Kind Regards

Guillaume