g-loot / react-tournament-brackets

React component library for displaying bracket leaderboards
https://sleepy-kare-d8538d.netlify.app/?path=/story/components-bracket--bracket
GNU Lesser General Public License v2.1
219 stars 69 forks source link

Development: Peer Dependency Errors #33

Closed ted537 closed 2 years ago

ted537 commented 2 years ago

npm install with npm v8.11.0 yields the following:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @mdx-js/react@1.6.22
npm WARN Found: react@18.1.0
npm WARN node_modules/react
npm WARN   dev react@"^18.1.0" from the root project
npm WARN   16 more (@emotion/core, @emotion/styled, @emotion/styled-base, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.13.1 || ^17.0.0" from @mdx-js/react@1.6.22
npm WARN node_modules/@mdx-js/react
npm WARN   @mdx-js/react@"1.6.22" from @mdx-js/loader@1.6.22
npm WARN   node_modules/@mdx-js/loader
npm WARN   1 more (@storybook/addon-docs)
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1 || ^17.0.0" from @mdx-js/react@1.6.22
npm WARN   node_modules/@mdx-js/react
npm WARN     @mdx-js/react@"1.6.22" from @mdx-js/loader@1.6.22
npm WARN     node_modules/@mdx-js/loader
npm WARN     1 more (@storybook/addon-docs)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @storybook/addon-actions@6.4.22
npm ERR! Found: react@18.1.0
npm ERR! node_modules/react
npm ERR!   dev react@"^18.1.0" from the root project
npm ERR!   peer react@">=16.3.0" from @emotion/core@10.3.1
npm ERR!   node_modules/@emotion/core
npm ERR!     peer @emotion/core@"^10.0.27" from @emotion/styled@10.3.0
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^10.0.27" from @storybook/theming@6.4.22
npm ERR!       node_modules/@storybook/theming
npm ERR!         @storybook/theming@"6.4.22" from @storybook/addon-actions@6.4.22
npm ERR!         node_modules/@storybook/addon-actions
npm ERR!         12 more (@storybook/addon-backgrounds, ...)
npm ERR!     peer @emotion/core@"^10.0.28" from @emotion/styled-base@10.3.0
npm ERR!     node_modules/@emotion/styled-base
npm ERR!       @emotion/styled-base@"^10.3.0" from @emotion/styled@10.3.0
npm ERR!       node_modules/@emotion/styled
npm ERR!         @emotion/styled@"^10.0.27" from @storybook/theming@6.4.22
npm ERR!         node_modules/@storybook/theming
npm ERR!     3 more (@storybook/theming, @storybook/ui, emotion-theming)
npm ERR!   15 more (@emotion/styled, @emotion/styled-base, downshift, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional react@"^16.8.0 || ^17.0.0" from @storybook/addon-actions@6.4.22
npm ERR! node_modules/@storybook/addon-actions
npm ERR!   dev @storybook/addon-actions@"^6.4.22" from the root project
npm ERR!   @storybook/addon-actions@"6.4.22" from @storybook/addon-essentials@6.4.22
npm ERR!   node_modules/@storybook/addon-essentials
npm ERR!     dev @storybook/addon-essentials@"^6.4.22" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peerOptional react@"^16.8.0 || ^17.0.0" from @storybook/addon-actions@6.4.22
npm ERR!   node_modules/@storybook/addon-actions
npm ERR!     dev @storybook/addon-actions@"^6.4.22" from the root project
npm ERR!     @storybook/addon-actions@"6.4.22" from @storybook/addon-essentials@6.4.22
npm ERR!     node_modules/@storybook/addon-essentials
npm ERR!       dev @storybook/addon-essentials@"^6.4.22" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/ted/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ted/.npm/_logs/2022-07-20T22_56_22_013Z-debug-0.log
ted537 commented 2 years ago

Upgrading all of the @storybook/... dependencies in package.json appears to resolve the errors at least.

npm install --upgrade @storybook/addon-actions @storybook/addon-essentials @storybook/addon-links @storybook/addon-storysource @storybook/react
Shenato commented 2 years ago

Really nice find, making a quick PR now.