feat: docker-compose 환경 구성 - [merged] #51

Closed halucinor closed 1 year ago

In GitLab by @haaeee on Feb 1, 2023, 15:24

Merges feature/docker -> develop

작업 내용

로컬 환경과 통합 테스트 코드를 작성할 때 mysql8을 제공

mem:h2는 개발 환경인 mysql8 데이터베이스 모드를 지원하지않기에 테스트 컨테이너를 구성하려고합니다.

docker-compose를 통해 docker-compose 명령어를 통해 빠르게 환경을 구성 (Redis, MySQL8)

테스트 컨테이너를 사용하여 테스트 환경 동일하게 맞췄습니다.
- Redis:6
- MySQL8

스크린샷

로컬 환경

테스트 환경

주의사항

Closes #13

[x] 💯 테스트는 잘 통과했나요?
[x] 🏗️ 빌드는 성공했나요?
[x] 🧹 불필요한 코드는 제거했나요?
[x] 💭 이슈는 등록했나요?
[x] 🏷️ 라벨은 등록했나요?
[x] 💻 git rebase를 사용했나요?

In GitLab by @haaeee on Feb 1, 2023, 15:24

requested review from @AnTaeWook

In GitLab by @haaeee on Feb 1, 2023, 15:34

added 1 commit

336e1d05 - chore: application.yml 테스트 profile 추가

Compare with previous version

In GitLab by @rkdud1108 on Feb 1, 2023, 15:42

approved this merge request

In GitLab by @AnTaeWook on Feb 1, 2023, 15:42

Commented on src/main/java/com/gabia/bshop/repository/MemberRepository.java line 9

미사용 코드나 추후 사용예정인 코드는 주석처리보다는 삭제하는 것이 혼동이 적을 것 같습니다~.~

In GitLab by @AnTaeWook on Feb 1, 2023, 15:42

Commented on src/test/java/com/gabia/bshop/TestContainerTest.java line 31

컨테이너 테스트는 통합테스트의 느낌인데 미리 만들어주신 Integration 상속받는 것은 어떤가요?
테스트 이름만으로 어떤 행위를 검증하는지 알 수 있으면 더 좋을 것 같습니다
given, when, then 패턴을 적용하면 추후에 테스트코드를 파악하기 좋을 것 같습니다

In GitLab by @AnTaeWook on Feb 1, 2023, 15:42

Commented on src/test/java/com/gabia/bshop/integration/IntegrationTest.java line 12

이건 개인적인 취향인데, 레디스 버전이 더 자세히 명시되면 좋을 것 같습니다!

In GitLab by @halucinor on Feb 1, 2023, 15:43

approved this merge request

In GitLab by @halucinor on Feb 1, 2023, 15:43

이슈 번호 기록 부탁드립니다.

In GitLab by @haaeee on Feb 1, 2023, 15:47

넵! 수정하였습니다.

In GitLab by @haaeee on Feb 1, 2023, 15:51

Commented on src/test/java/com/gabia/bshop/integration/IntegrationTest.java line 12

redis:6.2.7 버전, mysql:8.0.31 버전으로 고정하였습니다.

In GitLab by @haaeee on Feb 1, 2023, 15:53

Commented on src/main/java/com/gabia/bshop/repository/MemberRepository.java line 9

changed this line in version 3 of the diff

In GitLab by @haaeee on Feb 1, 2023, 15:53

Commented on src/test/java/com/gabia/bshop/TestContainerTest.java line 31

changed this line in version 3 of the diff

In GitLab by @haaeee on Feb 1, 2023, 15:53

Commented on src/test/java/com/gabia/bshop/integration/IntegrationTest.java line 12

changed this line in version 3 of the diff

In GitLab by @haaeee on Feb 1, 2023, 15:53

added 4 commits

703feb7a - style: MemberRepository 사용하지 않은 코드 삭제
aa084d76 - chore: mysql 8.0.31 버전으로 고정
d6ffb35b - test: mysql 8.0.31, redis:6.2.7 버전으로 고정
b5164d69 - test: given when then 추가 및 테스트 클래스 명 변경

Compare with previous version

In GitLab by @haaeee on Feb 1, 2023, 17:00

Commented on src/test/java/com/gabia/bshop/TestContainerTest.java line 31

명시적으로 테스트 이름을 변경하였습니다.

given, when, then 도 추가하였는데 어때욥?

In GitLab by @AnTaeWook on Feb 1, 2023, 17:01

Commented on src/test/java/com/gabia/bshop/TestContainerTest.java line 31

좋아욥!

In GitLab by @AnTaeWook on Feb 1, 2023, 17:01

approved this merge request

In GitLab by @haaeee on Feb 1, 2023, 17:01

mentioned in commit 344e97b34987e406e8e6a76a0d4f538d88bd89ae

In GitLab by @AnTaeWook on Feb 1, 2023, 17:01

mentioned in commit ad82c0b6534d5da549c6e919e539d8476fd325fa

In GitLab by @haaeee on Feb 3, 2023, 16:08

mentioned in commit 9c16a60c780f845cdac78060ec57e59a4244b34d

In GitLab by @haaeee on Feb 6, 2023, 10:37

mentioned in commit 4ee5427a2ce3988a8aadadac4b863c600999b7ba

In GitLab by @halucinor on Feb 6, 2023, 11:46

mentioned in commit e655d4df0d0592fb74779289c3d33dd09f3c922c

In GitLab by @halucinor on Feb 6, 2023, 13:13

mentioned in commit dd5c000e4b21c7e38f3b4c9157bb9486fd90ec35

In GitLab by @haaeee on Feb 6, 2023, 13:17

mentioned in commit 5383262241f0a1c2ad96b7dc4f6f363d76d3ce46

In GitLab by @halucinor on Feb 6, 2023, 15:32

mentioned in commit ea9e44b741bd93908283f1a012d409d9a27d2d03

In GitLab by @haaeee on Feb 8, 2023, 11:06

mentioned in commit 9ed3224c688bdca7b7db11ae0b6dae306eb6b2b0

In GitLab by @haaeee on Feb 8, 2023, 14:20

mentioned in commit 89de7246ed62d2195cc7895ea1c67804b5c285c2

In GitLab by @halucinor on Feb 21, 2023, 12:59

mentioned in commit 9a043ac60e0ac7fde962795a9ff59eaf4f2e8b42

In GitLab by @haaeee on Mar 7, 2023, 10:00

mentioned in commit 07d25fd7dbcc3ecadd855f90f140b2f2b61d3c1f

In GitLab by @halucinor on Mar 8, 2023, 17:23

mentioned in commit 2e0e481faed37aba8c40035da5d200b28c6ed1af

In GitLab by @halucinor on Mar 8, 2023, 22:35

mentioned in commit 9b6efe6bde5fbf30a19e6118d5a5900e2e962383

In GitLab by @rkdud1108 on Mar 18, 2023, 12:58

mentioned in commit f69407b6bce153198d48f198c33983b58b0e3a85

g-market / b-shop-backend