feat: 주문목록 조회 API 구현, 데이터 초기화 클래스 생성 - [merged]

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 11:04

Merges feature/getOrderInfos -> develop

작업 내용

주문목록 조회 API 구현, 데이터 초기화 클래스 생성

스크린샷

주의사항

@mentee/mentee_2023.01/team/g-market

14 #15

• [X] 💯 테스트는 잘 통과했나요?
• [X] 🏗️ 빌드는 성공했나요?
• [X] 🧹 불필요한 코드는 제거했나요?
• [X] 💭 이슈는 등록했나요?
• [X] 🏷️ 라벨은 등록했나요?
• [X] 💻 git rebase를 사용했나요?

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 11:04

requested review from @halucinor

[halucinor]

In GitLab by @haaeee on Feb 3, 2023, 13:33

Commented on src/main/java/com/gabia/bshop/repository/OrderItemRepository.java line 14

Summer님

@Param 지우셔도 아마 동작할거에요~

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 13:34

added 1 commit

• c2d257b9 - feat: 메서드 파라미터, 필드 final 키워드 추가

Compare with previous version

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 13:36

Commented on src/main/java/com/gabia/bshop/repository/OrderItemRepository.java line 14

감사합니다. 개인적인 습관이었는데, 작성한 쿼리메서드에서 @Param 모두 지우도록 하겠습니다

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 13:36

resolved all threads

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 13:37

Commented on src/main/java/com/gabia/bshop/repository/OrderItemRepository.java line 14

changed this line in version 3 of the diff

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 13:37

added 1 commit

• e8395327 - feat: 쿼리 메서드 @Param 제거

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 3, 2023, 13:44

resolved all threads

[halucinor]

In GitLab by @haaeee on Feb 3, 2023, 13:49

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

EntityNotFoundException 예외가 있는데 왜 IllegalStateException 사용하신 이유가 있으실까요?

final Member member = memberRepository.findByHiworksId(hiworksProfileResponse.hiworksId())
                .orElseThrow(() -> new EntityNotFoundException("관리자로 등록되지 않으셨습니다."));

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 14:10

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

커스텀한 예외를 잘 알지 못해서 Illegal 류의 예외만 사용한 것 같습니다. 변경하도록 하겠습니다!

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 14:13

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

changed this line in version 4 of the diff

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 14:13

added 1 commit

• d38df0d3 - feat: custom exception 으로 변경

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 3, 2023, 15:10

resolved all threads

[halucinor]

In GitLab by @halucinor on Feb 3, 2023, 15:12

Commented on src/main/java/com/gabia/bshop/controller/OrderController.java line 19

Page기능에 최대 갯수 제한을 걸어야하는 이유가 있을까요?

[halucinor]

In GitLab by @halucinor on Feb 3, 2023, 15:13

Commented on src/main/java/com/gabia/bshop/dto/response/OrderInfoPageResponse.java line 9

가독성을 위해 여러줄로 나누는건 어떨까요?

[halucinor]

In GitLab by @halucinor on Feb 3, 2023, 15:20

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

그냥 질문인데 아래와 같은 형태로 만들었을 때 메시지는 어떻게 넣어줘야할까요?

memberRepository.findById(memberId).orElseThrow(EntityNotFoundException::new)

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 15:38

Commented on src/main/java/com/gabia/bshop/controller/OrderController.java line 19

사실은 존재하지 않는 요구사항에 대한 validation 을 구현했습니다. 유저가 악의적으로 한 페이지에 너무 많은 데이터를 불러오려고 할 때를 방지하기 위한 제약사항입니다

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 15:39

Commented on src/main/java/com/gabia/bshop/dto/response/OrderInfoPageResponse.java line 9

changed this line in version 5 of the diff

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 15:39

added 1 commit

• 809eed8e - style: 코드 가독성 향상을 위한 개행 추가

Compare with previous version

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 15:39

Commented on src/main/java/com/gabia/bshop/dto/response/OrderInfoPageResponse.java line 9

가독성을 위해 개행을 추가했습니다! 감사합니다

[halucinor]

In GitLab by @AnTaeWook on Feb 3, 2023, 15:40

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

잘 모르겠습니다.. 메서드 참조를 자주 사용하지 않고, 메세지를 빼본적이 없어서요ㅠ
혹시 관련 정보를 받아볼 수 있을까요?

[halucinor]

In GitLab by @halucinor on Feb 3, 2023, 15:41

Commented on src/main/java/com/gabia/bshop/service/OrderService.java line 33

@haaeee 와 이야기 해보니 해당 형태로 메시지를 따로 추가하기는 힘들거 같습니다. Exception handling에 관해서는 다음주에 한번 회의하는 시간을 가지는건 어떨까요?

[halucinor]

In GitLab by @halucinor on Feb 3, 2023, 16:13

resolved all threads

[halucinor]

In GitLab by @haaeee on Feb 4, 2023, 21:15

approved this merge request

[halucinor]

In GitLab by @AnTaeWook on Feb 5, 2023, 16:03

mentioned in commit 6e3ec1a41dd6154c8f885ffc3303855018b63b90

[halucinor]

In GitLab by @halucinor on Feb 5, 2023, 16:03

mentioned in commit e61fd590330d41462d580d964f5deccc2b795b0e

[halucinor]

In GitLab by @AnTaeWook on Feb 6, 2023, 10:37

mentioned in commit 028cfbf0175f6997598dd6e1f34571f7d12a5760

[halucinor]

In GitLab by @AnTaeWook on Feb 6, 2023, 13:13

mentioned in commit e54723dc4bcfb255a5f518b89bb08322a57bd7e3

[halucinor]

In GitLab by @halucinor on Feb 6, 2023, 15:32

mentioned in commit ea9e44b741bd93908283f1a012d409d9a27d2d03

[halucinor]

In GitLab by @halucinor on Feb 21, 2023, 12:59

mentioned in commit 9a043ac60e0ac7fde962795a9ff59eaf4f2e8b42

[halucinor]

In GitLab by @haaeee on Mar 7, 2023, 10:00

mentioned in commit 07d25fd7dbcc3ecadd855f90f140b2f2b61d3c1f

[halucinor]

In GitLab by @halucinor on Mar 8, 2023, 17:23

mentioned in commit 2e0e481faed37aba8c40035da5d200b28c6ed1af

[halucinor]

In GitLab by @halucinor on Mar 8, 2023, 22:35

mentioned in commit 9b6efe6bde5fbf30a19e6118d5a5900e2e962383

[halucinor]

In GitLab by @rkdud1108 on Mar 18, 2023, 12:58

mentioned in commit f69407b6bce153198d48f198c33983b58b0e3a85