g-market / b-shop-backend

0 stars 0 forks source link

refactor: token properties - [merged] #69

Closed halucinor closed 1 year ago

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 13:16

Merges refactor/token-properties -> develop

작업 내용

http://mentoring-gitlab.gabia.com/mentee/mentee_2023.01/team/g-market/gabia_b_shop_backend/-/merge_requests/17#note_2031

이에 따른 TokenProperties를 하나의 클래스로 생성해서 이를 주입 받는 방식으로 변경하였습니다.

주의사항

Merges !17

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 13:16

requested review from @halucinor

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 15, 2023, 16:47

Commented on src/test/java/com/gabia/bshop/fixture/TokenPropertiesFixture.java line 13

SECRET 값이 코드에 들어가있어도 괜찮을까요?

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 18:03

added 7 commits

Compare with previous version

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 18:05

resolved all threads

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 18:05

enabled an automatic merge when the pipeline for b2dc679ceeb234b1d00b2b0aba5ad1642081533b succeeds

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 18:11

mentioned in commit b438d1ccacd6673b023fe115ca16d179ccf350df

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 15, 2023, 18:11

mentioned in commit 1d2060996ae6608161ec5f91dd082ded0626ccde

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 21, 2023, 12:59

mentioned in commit 9a043ac60e0ac7fde962795a9ff59eaf4f2e8b42

halucinor commented 1 year ago

In GitLab by @haaeee on Mar 7, 2023, 10:00

mentioned in commit 07d25fd7dbcc3ecadd855f90f140b2f2b61d3c1f

halucinor commented 1 year ago

In GitLab by @halucinor on Mar 8, 2023, 17:23

mentioned in commit 2e0e481faed37aba8c40035da5d200b28c6ed1af

halucinor commented 1 year ago

In GitLab by @halucinor on Mar 8, 2023, 22:35

mentioned in commit 9b6efe6bde5fbf30a19e6118d5a5900e2e962383

halucinor commented 1 year ago

In GitLab by @rkdud1108 on Mar 18, 2023, 12:58

mentioned in commit f69407b6bce153198d48f198c33983b58b0e3a85