g-market / b-shop-backend

0 stars 0 forks source link

feat: 상품 이력조회 기능 `envers` 적용 - [merged] #74

Closed halucinor closed 1 year ago

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 21, 2023, 16:48

_Merges feature/itemenvers -> develop

작업 내용

implement

implementation 'org.springframework.data:spring-data-envers'

@Audit annotation

주의사항

Issues #41

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 21, 2023, 16:48

requested review from @haaeee

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 10:34

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 45

final 키워드 변경하시고 원래 위치인 itemImage 필드 위에 정리하시면 될 것 같습니다.

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 16:18

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 45

changed this line in version 2 of the diff

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 16:18

added 1 commit

Compare with previous version

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 16:18

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 45

키워드 변경 및 itemImage 필드 위치 변경했습니다 :smile:

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 16:32

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 71

띄어쓰기 한번 해주시곘어용??

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 16:34

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 77

DB에서는 null이 안들어가니까 int로 변경하는게 더 좋을 것 같습니다!

Integer를 하면 결국 추후에 조회쿼리를 작성할때도 자동형변환의 과정이 한번 추가될 것 같습니다.

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 17:50

resolved all threads

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 17:52

Commented on src/main/java/com/gabia/bshop/entity/Item.java line 77

changed this line in version 3 of the diff

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 17:52

added 8 commits

Compare with previous version

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 17:52

enabled an automatic merge when the pipeline for f2cc72f97b6fa2426a684dd816eaaa9c7d005ce0 succeeds

halucinor commented 1 year ago

In GitLab by @halucinor on Feb 22, 2023, 17:58

mentioned in commit c151ddbfc089c2a7ae6736ffd4fa7fc6d676c607

halucinor commented 1 year ago

In GitLab by @haaeee on Feb 22, 2023, 17:58

mentioned in commit 32bb3343e25281e4ac5003c8fbc112107f7ae0fd

halucinor commented 1 year ago

In GitLab by @haaeee on Mar 7, 2023, 10:00

mentioned in commit 07d25fd7dbcc3ecadd855f90f140b2f2b61d3c1f

halucinor commented 1 year ago

In GitLab by @halucinor on Mar 8, 2023, 17:23

mentioned in commit 2e0e481faed37aba8c40035da5d200b28c6ed1af

halucinor commented 1 year ago

In GitLab by @halucinor on Mar 8, 2023, 22:35

mentioned in commit 9b6efe6bde5fbf30a19e6118d5a5900e2e962383

halucinor commented 1 year ago

In GitLab by @rkdud1108 on Mar 18, 2023, 12:58

mentioned in commit f69407b6bce153198d48f198c33983b58b0e3a85