search

g-plane / pnpm-shell-completion

Complete your pnpm command fastly.
MIT License
119 stars 10 forks source link

build: use REAL m1 runner for aarch64 darwin builds #16

Closed TinkoLiu closed 7 months ago

TinkoLiu commented 7 months ago

This commit fixed the wrong configuration in GitHub Workflow.

According to this document, macos-latest is an alias of macos-12 at present, which leads to a wrong build architecture in the assets.

This is the executable from the latest release (v0.5.3):

Info:
    File name: pnpm-shell-completion_aarch64-apple-darwin (053)/pnpm-shell-completion
    Size: 1980624
    Operation system: macOS(12.0.0)
    Architecture: X86_64
    Mode: 64-bit
    Type: EXECUTE
    Endianness: LE

And here is the new one:

Info:
    File name: pnpm-shell-completion_aarch64-apple-darwin/pnpm-shell-completion
    Size: 1810024
    Operation system: macOS(14.0.0)
    Architecture: ARM64
    Mode: 64-bit
    Type: EXECUTE
    Endianness: LE
TinkoLiu commented 7 months ago

I have not install Rosetta on purpose, and got failed when I try using fish.

If you have Rosetta installed, everything would works just fine. But without Rosetta, it throws Bad CPU type in executable.