search

g-plane / zsh-yarn-autocompletions

Zsh plugin for Yarn autocompletions.
MIT License
578 stars 18 forks source link

Add favorite dependencies (#10) #12

Closed danielbayerlein closed 6 years ago

danielbayerlein commented 6 years ago

based on https://gist.github.com/anvaka/8e8fa57c7ee1350e3491. Issue #10

danielbayerlein commented 6 years ago

@g-plane

And can you fix the test?

I just do not understand why the test fails, can you help me? typescript is excluded inyarn-autocompletions.example.yml and should not be displayed.

g-plane commented 6 years ago

It may be a bug. I'm checking now.

g-plane commented 6 years ago

OK. This is not a bug. And I know why the tests will fail.

You have added @babel/preset-typescript while the test will check whether the output contains typescript (see https://github.com/g-plane/zsh-yarn-autocompletions/blob/7f3b341c873f1905af1771fcb8c236566cc3eb6a/yarn-autocompletions.example.yml#L9). The string @babel/preset-typescript contains string typescript and it is the reason why the test failed. (However it works in fact.)

The solution is use another package name (such as xo). Would you like to update it?

danielbayerlein commented 6 years ago

@g-plane Thank you! I will update the test.

danielbayerlein commented 6 years ago

@g-plane Done 😉