g-serghei / brackets-phplinter

This extension works using `php -l` command
MIT License
1 stars 0 forks source link

Breaks JSLint #3

Open FrancescoBorzi opened 9 years ago

FrancescoBorzi commented 9 years ago

Hello,

this plugin breaks the JSLint each time you change the *.js file you are working on, JSLint is stuck like if it's disabled, for example I can remove a final ; of a row and save but it won't show any error.

If you go to the View menu and disable/enable the lint files on saving it will work again, but it will break on next file change.

amitkeret commented 9 years ago

I can confirm and add:

In my installation, I realized that linting was not checking files on save, even though View -> Lint Files on Save was enabled in the main menu. After re-installing all extensions in sequence, I found that this extension breaks this functionality. If you close and re-open a file, linting happens. It just happens once. When saving the file again, it will not lint.

Important - the ONLY linting that does work on save is of this extension. When saving a php file the linter runs and reports errors as expected. So - it seems that your extension "hijacks" the lint on save functionality and blocks it from executing any other linters.

timothylrobb commented 8 years ago

I can also confirm that this breaks js linting on save. The jslint works temporarily if I disable it and re-enable it, but then it breaks again when I switch files. JSLint does run when I switch between JavaScript files. Fortunately, there is an alternative to this extensions called: PHP Code Quality Tools. However, it would be nice to see this get fixed, or removed from the list of extensions if it is no longer being maintained.