search

g-tejas / pe

0 stars 0 forks source link

Jar file contains bloat #5

Open g-tejas opened 4 months ago

g-tejas commented 4 months ago

Description

AS shown in the screenshot below, there are multiple images (the clock, fail, etc), which i do not see used in the application itself.

Screenshots

CleanShot 2024-04-19 at 16.46.02@2x.png

Steps to reproduce

  1. Change .jar to .zip
  2. Unzip
  3. Open the images/ dir

Expected vs Actual Behaviour

The jar file should only contain images that are used to reduce bloat. AS mentioned here

CleanShot 2024-04-19 at 16.47.21@2x.png

Suggestion

REmove this images

nus-se-script commented 4 months ago

Team's Response

Thanks for raising this. This is a valid viewpoint to consider, however the images may be used in later versions. Furthermore, the images are of relatively small size less than MB of file size, which only affects the file size by a minuscule amount. Thus it does not effectively bloat the application

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]