search

g-tejas / pe

0 stars 0 forks source link

Meeting do not have duration #7

Open g-tejas opened 4 months ago

g-tejas commented 4 months ago

Description

The application doesn't allow durations to be associated with a meeting. This feels weird as normally, calendar apps allow durations, and there is validation to chceck if there are any overlapping meetings, however, as you can see below, there are two meetings with everything the same except the time which is 1 minute apart. The user might mistakenly add duplicate meetings with slightly diff times, however the application doesn't detect this, since there's no duration. All meetings are implicitly 1 minute long since thats the smallest unit of time stored.

Apart from correcntess, it is also very helpful to know how long a meeting is, whcih might affect his other commands to add meetings for other people.

Screenshots

CleanShot 2024-04-19 at 16.59.04@2x.png

Steps to reproduce

  1. Run command: meeting-add 1 d/Meet for finals preparation s/29/02/2024 18:00
  2. Run command: meeting-add 1 d/Meet for finals preparation s/29/02/2024 18:01

    Expected vs Actual Behaviour

Suggestion

Add durations to the application, and also validation to check if there are any overlapping meetings

nus-se-bot commented 4 months ago

Team's Response

Thanks for raising this. This is intended, as a meeting is not restricted by having an end time. e.g A student can set up a consultation with a professor that starts at a certain time, but does not know how much time they may take during the consult. Our team not want to restrict on a user input how they wish to segregate meetings of different topics that may occur at the same time as stated here.

image.png

and in the Q and A as well image.png

As to why 1 minute meetings are allowed it may be intentional by some users to have minute meeting (maybe a minute dance) and then continue with a different topic after that minute meeting. It would be difficult to identify genuine cases of 1 minute meeting and those that mistakenly type 1 minute meetings, hence our team has decided to allow meetings at any point of time to satisfy everyone, and lets the user decide if it is intended or not.

Furthermore, not all calendar applications have a validation check that checks for conflicting meetings or meetings that are 1 minute long. An example is Apple Calendar that allows meetings to occur with a 0 min time duration and concurrently at the same time with no conflicting checks

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]