search

g-truc / glm

OpenGL Mathematics (GLM)
https://glm.g-truc.net
Other
9.1k stars 2.12k forks source link

Build error on Android #1231

Closed xiaozhuai closed 7 months ago

xiaozhuai commented 7 months ago

See also https://github.com/microsoft/vcpkg/pull/36358

Here is the log install-arm64-android-dbg-out.log

It seems caused by these lines https://github.com/g-truc/glm/blob/33b0eb9fa336ffd8551024b1d2690e418014553b/glm/detail/setup.hpp#L299-L311

gottfriedleibniz commented 7 months ago

In the install logs you are compiling with -Weverything. Is this intentional?

Ah, -Weverything was moved into the main CMakeLists and a variety of pragma clang diagnostic's were added in source to compensate. Now, the CMakeLists expects an explicit standard flag to be enabled so it can disable the c++98-compat checks.

Don't think the documentation has been updated to reflect this (ergonomics? i.e., should -Weverything be enabled by default outside of the CI).

xiaozhuai commented 7 months ago

In the install logs you are compiling with -Weverything. Is this intentional?

No, I just specify following options.

-DGLM_BUILD_LIBRARY=ON
-DGLM_BUILD_TESTS=OFF
-DGLM_BUILD_INSTALL=ON

Should I pass GLM_ENABLE_CXX_xxxxx ?

christophe-lunarg commented 7 months ago

-Weverything includes -Wc++98-compat. If you don't want to get these warnings, you can build with -Weverything and -Wnoc++98-compat.

No need to pass GLM_ENABLE_CXX_xxxxx.