g-truc / glm

OpenGL Mathematics (GLM)
https://glm.g-truc.net
Other
9.05k stars 2.1k forks source link

Issue: Example Commands in README.md, in 'Build and Install' section, Label: Documentation #1300

Open ktprezes opened 2 months ago

ktprezes commented 2 months ago

Problem Description: In the readme.md#Build and Install section of the README, the 1st provided example does not work on Windows 11 with MSVS 2022. Specifically, the following lines have issues:

cmake --build build -- all
cmake --build build -- install

Possible Solution: After testing, I found that the correct commands should be:

cmake --build build --target ALL_BUILD
cmake --build build --target INSTALL

At least these commands work correctly on my system.

Justification: The current version of the commands might be confusing, especially for CMake beginners. Updating the commands in the README would likely help new users avoid confusion and build issues.

Thank you for your attention to this matter and for maintaining such a useful project!

Best regards, Tadeusz