g0dkar / qrcode-kotlin

QRCode Generator implemented in pure Kotlin
https://qrcodekotlin.com/
MIT License
192 stars 20 forks source link

Fix color converter in iOS #106

Closed ruicanas closed 11 months ago

ruicanas commented 12 months ago

Changes:

  1. [iOS & tvOS] Fixing a bug regarding colors parsing;
  2. [tvOS] Applied previous fixes;
  3. [iOS Demo App] Added extensions to parse NSData into a KotlinByteArray.

I found this issue a blocker on the usage of this awesome library, so I've opened this pull-request to fix it. I'd like to make some unit tests in iOS and tvOS modules and also add more scenarios to the iOS demo mode whenever I got some time.

ruicanas commented 12 months ago

Olá outra vez @g0dkar 😅 Another pull-request for review. Please take a look when you have a moment! The gradient is not working properly in iOS and I suspect it might be because of the color handling in iOS. I'll have to take a look whenever I have some time.

g0dkar commented 11 months ago

Heya, just a kind of late heads up: I'm on a business trip, so I'm a bit off. I'll be able to review and merge everything next week ^^