search

g0dkar / qrcode-kotlin

QRCode Generator implemented in pure Kotlin
https://qrcodekotlin.com/
MIT License
177 stars 18 forks source link

QR codes not being generated properly for iOS #92

Closed ruicanas closed 10 months ago

ruicanas commented 10 months ago

Describe the bug The method getBytes() from QRCodeGraphics is not giving the correct data to generate a QRCode.

To Reproduce

  1. Instantiate any type of QRCode and try to use getBytes() method.
  2. Try to use the ByteArray generated in an iOS app.

Expected behavior Expected the QRCode to be shown correctly once I pass the ByteArray to NSData, and then from NSData to UIImage.

Additional context I actually have a fix for this issue and I opened a PR for this. I have found another issue regarding the logos with a background color different than Colors.TRANSPARENT that only occurs in iOS. I don't know if this could be also a good place to talk about it.

ruicanas commented 10 months ago

Fixed and merged 😃