search

g0orx / linhpsdr

Linux HPSDR
GNU General Public License v3.0
74 stars 44 forks source link

rigctl.c:3422: strange expression ? #121

Open dcb314 opened 1 year ago

dcb314 commented 1 year ago

gcc compiler can be made to say:

rigctl.c:3422:64: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]

Source code is

        sprintf(reply,"SA%d%d%d%d%d%d%dSAT?  ;",rx->split==SPLIT_SAT|rx->split==SPLIT_RSAT,0,0,0,rx->split=SPLIT_SAT,rx->split=SPLIT_RSAT,0);

Maybe better code:

        sprintf(reply,"SA%d%d%d%d%d%d%dSAT?  ;",
            (rx->split==SPLIT_SAT || rx->split==SPLIT_RSAT)
            ,0,0,0, rx->split = SPLIT_SAT, rx->split = SPLIT_RSAT, 0);