update offers a dark mode compatible collection of Gdk background overrides

g0orx / pihpsdr

Raspberry Pi standalone code for HPSDR (Protocol 1 and Protocol 2)

GNU General Public License v2.0

105 stars 73 forks source link

update offers a dark mode compatible collection of Gdk background overrides #185

Open csylvain opened 1 year ago

csylvain commented 1 year ago

built pihpsdr and found all the menus were white text on white background. created a Makefile option to use new file bkgnd.h which contains a background color definition which is not 'white'. changed all the menu code to use the new option when enabled. note: the discovery menu is unique in that it is similar but not exactly the same override variable as all the others. also see #28

petrus-lt commented 1 year ago

I didn't tried this change but @markusgrosser one from #28, which works fine if you adapt it to current code (see my non-white-menu branch). Two things I see with your diff:

you also hardcode background colors, so now we have two options instead of one. Can't this be handled by the WM instead, like in @markusgrosser PR?
you added main.c with your custom resolution (1366x768) in the diff, this should be removed.

But without a change like this, pihpsdr is pretty unusable for me, so I'd welcome such a change.

dl1ycf commented 10 months ago

The dl1ycf version is now fully compatible with both white and dark mode, and does minimal fiddling around and leaves nearly everything to GTK.

petrus-lt commented 10 months ago

@dl1ycf Thanks, indeed. I found your fork afterwards. I'm using it now.

csylvain commented 10 months ago

i meant to mention the DL1YCF fork cured all the various hard-coded GTK stuff making PiHPSDR fully usable without regard to a user's theme choice.

glad to see you found your way to it, despite my inattention to this issue!

On Fri, Sep 15, 2023 at 4:58 AM petrus-lt @.***> wrote:

@dl1ycf https://github.com/dl1ycf Thanks, indeed. I found your fork afterwards. I'm using it now.

— Reply to this email directly, view it on GitHub https://github.com/g0orx/pihpsdr/pull/185#issuecomment-1720924542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRUYNM5MXV43F66O5PF3TTX2QKEDANCNFSM6AAAAAAYAYX3JM . You are receiving this because you authored the thread.Message ID: @.***>