g0v / twangry

政誌 - Angry event made in Taiwan.
http://fact.g0v.tw
Do What The F*ck You Want To Public License
51 stars 25 forks source link

event should only filter by event.tag, not include event.text #78

Closed starsdog closed 11 years ago

starsdog commented 11 years ago

如果打"污染", 會出現"蘇花高爭議", 但是此事件tag裡沒有污染, 是內文裡面有"污染".

starsdog commented 11 years ago

already commit code to fix this issue. 但是現在必須在打完filter字串按enter後才會做filter, 不像以前可以邊打邊filter

jimyhuang commented 11 years ago

要 git push code才會到remote(線上 https://github.com/g0v/twangry/commits/master ) 你之前怎麼用INSTALL.md的?

jimyhuang commented 11 years ago

commit裡頭可以下 "#78" 這樣 ,github會自動連結這個issue ~ ex:

fixes #78, only filter tag when user press tag
starsdog commented 11 years ago

commit裡面沒寫, 是不是就連結不到了

jimyhuang commented 11 years ago

如果是最後一個commit,還可以修改 git commit --amend 然後就可以開始修改

starsdog commented 11 years ago

如果是要改遠端呢? 是先改好local端的comment 然後再push到遠端(git push -u origin master) 這樣是嗎?

jimyhuang commented 11 years ago

試試看這樣有沒有用?

git commit --amend 
git pull 
git push
starsdog commented 11 years ago

被我弄得很亂呀. 又commit了一次一樣的. 只有log不同 然後pull多了一個merge的無謂log~

jimyhuang commented 11 years ago

賀!

jimyhuang commented 11 years ago

有個bug,就是點tag後,input的輸入框會變成

function (b){return a.get(b+c)}
starsdog commented 11 years ago

改好了, 你再玩玩看. 看有沒有其他問題

jimyhuang commented 11 years ago

trying ~~

jimyhuang commented 11 years ago

變成輸入框key-in後,沒有進行任何篩選 ~ XD 辛苦了

starsdog commented 11 years ago

"變成輸入框key-in後,沒有進行任何篩選" 輸入完有enter嗎? enter完會篩選, 但目前還無法邊輸邊篩