search

g1eb / angular-datetime-range

📅 Angular directive for datetime range input
https://rawgit.com/g1eb/angular-datetime-range/master/
MIT License
25 stars 14 forks source link

Capability to disable Calendar #17

Open manusoftar opened 6 years ago

manusoftar commented 6 years ago

I would like to ask if you could add an attribute to enable/disable the calendar part, the date if i want to use it only as a time range picker without date.

Also it would be nice to have the posibility to customize the text on the button to translate it.

Thanks.-

g1eb commented 6 years ago

Hi! Sure, we can make the calendar optional, sounds like an easy enough fix :)

Which button are you talking about specifically? The close button?

g1eb commented 6 years ago

Hi, someone else has asked for a similar functionality in #18 - ability to select a date range without specifying the time. These two requests seem similar enough to do them at the same time.

Which button were you referring to when you said you wanted to change the text of?

manusoftar commented 6 years ago

The "CLOSE" button, that is the only text i saw that was in english, i guess since angular is localizable any modules should be aswell, at least if you don't provide the translation, at least you can provide the devs that use your module a way to translate themselves without having to do a fork on your repo and rebuild the whole thing...

Thanks.

2018-03-20 11:38 GMT-03:00 Gleb notifications@github.com:

Hi, someone else has asked for a similar functionality in #18 https://github.com/g1eb/angular-datetime-range/issues/18 - ability to select a date range without specifying the time. These two requests seem similar enough to do them at the same time.

Which button were you referring to when you said you wanted to change the text of?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/g1eb/angular-datetime-range/issues/17#issuecomment-374621581, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7nA-grwMgulB9esNADug99zOTw25IEks5tgRRvgaJpZM4ST0rg .

g1eb commented 6 years ago

Thanks for clearing that up, I'll add this right away :)

Could you please open a separate issue for the close button text change? That way we can keep using this thread for time-range specific discussion.

manusoftar commented 6 years ago

No problem, i'll do it ASAP

El mar., 20 mar. 2018 12:55 PM, Gleb notifications@github.com escribió:

Thanks for clearing that up, I'll add this right away :)

Could you please open a separate issue for the close button text change? That way we can keep using this thread for time-range specific discussion.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/g1eb/angular-datetime-range/issues/17#issuecomment-374651090, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7nA0Li4nbM2S_o6jifZ4cQcZWwv3bCks5tgSZqgaJpZM4ST0rg .