search

g1eny0ung / hugo-theme-dream

🌱 A Hugo theme named Dream.
http://g1en.site/hugo-theme-dream/
MIT License
366 stars 132 forks source link

[Bug]: can't reorder or collapse about #318

Open diamantelist opened 1 month ago

diamantelist commented 1 month ago

Version

master

What browsers are you seeing the problem on?

Chrome, Firefox, Safari, Microsoft Edge

Describe the bug

Screenshot from 2024-09-13 01-45-19 Screenshot from 2024-09-13 01-46-17

I can't reorder or collapse ¨about" in any way even if I can do that with navItems and other pages. I tried to change even i18n (I'm using IT) but nothing happened.

To Reproduce

No response

diamantelist commented 1 month ago

On mobile it's automatically collapsed. By the way, I also tried EN i18n and still can't collapse it on desktop.

g1eny0ung commented 1 month ago

Yep, I've not included "about" in the reorderNavItems before. I'm not sure what I was thinking at the time, but I can add it now.

g1eny0ung commented 1 month ago

Yep, I've not included "about" in the reorderNavItems. I don't know what I was thinking then, but I can add it now.

There still a problem is: if "about" can be used in reorderNavItems, this will be a breaking change because some people may have already used reorderNavItems and it will override the default order.

One solution would be to create a new branch for this change and then I'm going to merge it into the master branch after 3 minor versions, what do you think of that? You can use the newly created branch temporarily before it merges into the master.

diamantelist commented 1 month ago

It would be great for me, thank you so much!

From: Yue Yang @.> Sent: Friday, September 13, 2024 4:02:21 PM To: g1eny0ung/hugo-theme-dream @.> Cc: diamantelist @.>; Author @.> Subject: Re: [g1eny0ung/hugo-theme-dream] [Bug]: can't reorder or collapse about (Issue #318)

Yep, I've not included "about" in the reorderNavItems. I don't know what I was thinking then, but I can add it now.

There still a problem is: if "about" can be used in reorderNavItems, this will be a breaking change because some people may have already used reorderNavItems and it will override the default order.

One solution would be to create a new branch for this change and then I'm going to merge it into the master branch after 3 minor versions, what do you think of that? You can use the newly created branch temporarily before it merges into the master.

— Reply to this email directly, view it on GitHubhttps://github.com/g1eny0ung/hugo-theme-dream/issues/318#issuecomment-2349039309, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2T572SAKM24WV5ZV7HCU4DZWLV63AVCNFSM6AAAAABOEIXQDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZGAZTSMZQHE. You are receiving this because you authored the thread.Message ID: @.***>

g1eny0ung commented 1 month ago

Added in https://github.com/g1eny0ung/hugo-theme-dream/tree/add-about-in-reorderNavItems.