search

g2384 / VHDLFormatter

VHDL formatter web online written in typescript
https://g2384.github.io/VHDLFormatter/
MIT License
51 stars 20 forks source link

Some fixes and a new feature #45

Open fenkes-ibm opened 3 years ago

fenkes-ibm commented 3 years ago

Improve indentation around multiline assignments, comma fixup feature, plus some minor updates.

fenkes-ibm commented 3 years ago

Let me know if you'd like me to create issues for the indentation fixes.

g2384 commented 3 years ago

Thanks for this PR. I noticed that one unit test failed (indent assignment statement (with comment)). How do you handle this case?

CONSTANT Vcc : SIGNAL := --logic 1 constant
'1';
CONSTANT zero4 : bit_vector(0 TO 3) :=--test
('0', '0', '0', '0');

The expected behavior would be:

CONSTANT Vcc : SIGNAL := --logic 1 constant
    '1';
CONSTANT zero4 : bit_vector(0 TO 3) := --test
    ('0', '0', '0', '0');
fenkes-ibm commented 3 years ago

Sorry for the long delay, busy with other work stuff right now :/ I had failed to run the jest testcases so I missed this. I found the bug but while doing so uncovered an inconsistency in my approach that I'd like to fix before pushing another set of changes. Coming up soon!

g2384 commented 3 years ago

I've added the jest into the github action. So if you merge master into your pr, github will check for you automatically.