search

g2p / rfc6266

Content-Disposition header support for Python
GNU Lesser General Public License v3.0
41 stars 44 forks source link

Version on PyPi out of date, raises AttributeError on parse_headers #12

Open jbrockmendel opened 8 years ago

jbrockmendel commented 8 years ago

As of 2016-10-29, the rfc6266 package on PyPi (https://pypi.python.org/pypi/rfc6266) is dated 2013-11-13. There is a typo in that version that has been fixed in the version on Github. Line 28 reads:

LOGGER.addHandler(logging.NullHandler)

instead of:

LOGGER.addHandler(logging.NullHandler())

So the call to LOGGER.debug inside parse_headers raises an AttributeError.

mbarszcz commented 7 years ago

@g2p Please let me know if I can help you out with releasing this -- this broke celery on our staging server today (it is executing .createLock() on all logging handlers and this fails for NullHandler class, but not instance).

angelkenneth commented 6 years ago

The version at pypi still has this line:

LOGGER.addHandler(logging.NullHandler)

instead of the latest:

LOGGER.addHandler(logging.NullHandler())

Great library, but please release a 0.0.5. So that we don't have to use rfc6266-parser.

graingert commented 4 years ago

@g2p there's another fork here https://github.com/ekzhu/rfc6266