g3n / demos

Standalone demos for G3N Game Engine
BSD 2-Clause "Simplified" License
14 stars 12 forks source link

Make g3nview build with latest engine version #6

Closed sashabaranov closed 5 years ago

sashabaranov commented 5 years ago

Hello,

I was trying to add glTF support to g3nview and found out that it is incompatible with latest engine version. This PR makes it build with latest engine, but it does break the g3nview 🙃

I did not manage to find how to do

gv.Renderer().SetGuiPanel3D(panel3D)

in current engine version. I've commented out this line and added TODO comment. If someone will point out what is the proper way to do this, I'll update pull request with [hopefully] working version with gltf support!

danaugrs commented 5 years ago

Thanks for the PR @sashabaranov! I'll merge and do the proper fixes. There is no more Panel3D in the renderer so it will be safe to remove that line.

danaugrs commented 5 years ago

@sashabaranov After https://github.com/g3n/demos/commit/c147c238a94409c1a39481dbb33e50b97fdc8f8f g3nview is now working properly 😄