Closed mat007 closed 3 years ago
I am not a brew expert, it looks a bit suspicious to me that installing the dependencies doesn’t create links from the usual include and lib locations (e.g. /usr/local/include
, /usr/local/lib
and such). 🤔
Hi and thanks for the PR!
Any reason to mix darwin, <arch>
(comma meaning AND) and darwin <arch>
(space meaning OR)?
A build constraint is evaluated as the OR of space-separated options. Each option evaluates as the AND of its comma-separated terms. source
If not, could you please update it to use commas only? Otherwise it looks great and I can merge it.
Any reason to mix darwin,
(comma meaning AND) and darwin (space meaning OR)?
Oh no, it’s a typo! Good catch, sorry about that. I should be all commas. I just re-pushed!
Great, thanks!
What I did: I duplicated the darwin
#cgo
lines for bothCFLAGS
andLDFLAGS
, and addedarm64
specific settings. This makes 'go install' work on Apple silicon out of the box after installing the dependencies with brew on a freshly installed machine.Hopefully fixes https://github.com/g3n/g3nd/issues/33
Before:
After
I also verified that switching to the
g3n/g3nd
folder and adding togo.mod
I was able to
go install
and run the demos.