search

g3rb3n / I2C

A wrapper around Wire with byte / mask / shift functionality
0 stars 0 forks source link

Wire.begin(sda, scl) order of sda and scl parameters. #1

Open Koepel opened 7 years ago

Koepel commented 7 years ago

Hi, I noticed something.

In the file "I2C.h" the name of the third parameter should be "scl", it is now:
I2C(uint8_t address, uint8_t sda, uint8_t cls);

In the file "I2C.cpp" you pass those parameters to the ESP8266 Wire library as:
Wire.begin(scl, sda);
but as far as I know, the ESP8266 Wire library also uses the order "sda, scl": esp8266 Wire.h

g3rb3n commented 7 years ago

Hi,

You are so right, I will fix this right away.

Thank you for reporting.