Complete pyg4ometry docker image

g4edge / dockerfiles

MIT License

0 stars 1 forks source link

Complete pyg4ometry docker image #3

Open stewartboogert opened 1 year ago

stewartboogert commented 1 year ago

We should have a complete docker image to run pyg4ometry (opposed to the build environment for testing)

I think it would be nice if changes in the docker file triggered a container build on docker hub. Do we already do this?
There is lots of instruction on getting the graphics running (in bitbucket issues) within a container we can consolidate in the manual
I think we should pay for more significant docker resources

gipert commented 1 year ago

I should have enabled automated builds on DockerHub, triggered by pushes and PRs: https://hub.docker.com/repository/docker/g4edge/pyg4ometry/builds

PS: not sure about resources limits on DockerHub.

stewartboogert commented 1 year ago

Right, but where should we put the docker file that includes the build of pyg4ometry and VNC/Xwindows etc. I could put a directory like ubuntu-pyg4ometry in the docker repo. Or I could put this in the main pyg4ometry repository

gipert commented 1 year ago

I would propose to name the base Docker images just ubuntu, manylinux2014_x86_64, ... and create a new "production ready" image (with pyg4ometry) named just `pyg4ometry". I would install any extra dependencies like VNC/Xwindows in the base images.

gipert commented 1 year ago

https://github.com/g4edge/dockerfiles/commit/b356e617e5fc9439320129ecf43089dcb51ba987