resubmit the udid support, plus the fix of rpt_hat_tgo board name string

g4klx / MMDVM

The firmware for the MMDVM (Multi-Mode Digital Voice Modem)

GNU General Public License v2.0

473 stars 188 forks source link

resubmit the udid support, plus the fix of rpt_hat_tgo board name string #209

Closed shawnchain closed 4 years ago

shawnchain commented 5 years ago

resubmit the pr changes

g4klx commented 5 years ago

Can you explain what the UDID is used for? Secondly, can you not create a hex value without using the standard library? I think it would be better to not use sprintf.

shawnchain commented 5 years ago

just wanna to add some unique identifier to the modem, like MAC address of the device so that host program could distinguish them

g4klx commented 5 years ago

I am completely unconvinced about UDID and the implementation is poor. The fix for the RPT_HAT_TGO is fine though. In the three and a half years that the MMDVM has existed, the need for a UDID has never occurred.

g4klx commented 4 years ago

UDID support has been added to the firmware in branch M17_AX25_FM which will become the standard version soon. It is sent to the host as binary data in the new format for the version data in serial protocol version 2. I will close this PR as all of its features are now in the firnware.