g4klx / MMDVMHost

The host program for the MMDVM
GNU General Public License v2.0
378 stars 274 forks source link

reverse bit and byte order of DMR trellis decoded data #744

Closed iddq closed 1 year ago

iddq commented 2 years ago

Hi Jonathan,

I assume the bits and bytes from trellis decoder are in reverse order which may wrong... This is true for data from both the MMDVM and the network.

to reproduce the issue I sent text in motorola format which use data rate 3/4 and used the code below:

https://github.com/iddq/MMDVMHost/commit/6a9467c395900a6115c22d44c9ad34cd2a12de90

I've tried to compare it with other implementation but it is beyond my knowledge.

https://github.com/pd0mz/go-dmr/blob/ecea90fd7937aa1b145f304e28a3870790b161ff/terminal/terminal.go#L506

iddq commented 2 years ago

cc: @g4klx

iddq commented 1 year ago

up

iddq commented 1 year ago

cc: @g4klx