g4klx / ircDDBGateway

The ircDDB Gateway for D-Star

GNU General Public License v2.0

61 stars 41 forks source link

Wrong tag order for APRS packets with altitude and range #43

Open sp5lg opened 5 years ago

sp5lg commented 5 years ago

Current APRS packet sending altitude (/A=) and range (RNG) is wrong resulting in data misinterpretation showing RNG tag as comment. This is a result of wrong tag order. According to APRS spec http://www.aprs.org/doc/APRS101.PDF chapter 7 and 8, RNG is a special tag for range and is supposed to be sent before comment while /A= tag is a comment tag.

Packet SP5LG-B>APDG02,TCPIP*,qAC,SP5LG-BS:!5215.03ND02101.33E&/A=000000RNG0000 440 Voice 439.90000MHz -9.5000MHz Result as seen on aprsdirect.com wrong

sp5lg commented 5 years ago

I've already placed a fix for this here https://github.com/g4klx/ircDDBGateway/pull/42

g4klx commented 5 years ago

Your patch is good. I’m waiting to get a chance to check the other modes APRS code for the same bug. It will be committed when I get a chance to check.

Sent from Yahoo Mail for iPhone

On Saturday, September 28, 2019, 22:56, sp5lg notifications@github.com wrote:

I've already placed a fix for this here

42

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.