g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

#7 extract interfaces and set up pg tests #15

Closed olenagerasimova closed 5 years ago

olenagerasimova commented 5 years ago

For #7 User and Users interfaces were extracted. I've also set up DatabaseITCase class for embedded postgres integration tests.

0crat commented 5 years ago

Job #15 is now in scope, role is REV

0crat commented 5 years ago

This pull request #15 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

olenagerasimova commented 5 years ago

@victornoel thanks for review, I've made changes, please, take look. BTW there is no @Rule in JUnit 5 therefore I've transformed PgUserITCase into JUnit 5 Extension.

olenagerasimova commented 5 years ago

@victornoel corrected, take a look please

victornoel commented 5 years ago

@olenagerasimova great, thank you for your patience, it is the beginning of the project so we must be careful not to introduce bad practices ;)

@g4s8 should be alright I think

g4s8 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 2min)

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

The job #15 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

ammaratef45 commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @victornoel/z

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z