Closed olenagerasimova closed 5 years ago
This pull request #15 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job
@victornoel thanks for review, I've made changes, please, take look. BTW there is no @Rule
in JUnit 5 therefore I've transformed PgUserITCase
into JUnit 5 Extension.
@victornoel corrected, take a look please
@olenagerasimova great, thank you for your patience, it is the beginning of the project so we must be careful not to introduce bad practices ;)
@g4s8 should be alright I think
@rultor merge
@rultor merge
@g4s8 OK, I'll try to merge now. You can check the progress of the merge here
@0crat quality good
For #7
User
andUsers
interfaces were extracted. I've also set upDatabaseITCase
class for embedded postgres integration tests.