g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

Telegram takes depend on db source #45

Closed olenagerasimova closed 5 years ago

olenagerasimova commented 5 years ago

TkNotifications and TkThread depend on database source now, I believe that's completely wrong. These classes should have Users field instead of DataSource to keep low abstraction coupling and make unit testing possible and easy (we simply create Users.Fake implementation and will be happy). UPD We also got rid of datasource dependency in BotApp.java.

0crat commented 5 years ago

@g4s8/z please, pay attention to this issue

0crat commented 5 years ago

Job #45 is now in scope, role is DEV

0crat commented 5 years ago

Bug was reported, see §29: +15 point(s) just awarded to @olenagerasimova/z

0crat commented 5 years ago

The job #45 assigned to @scristalli/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

scristalli commented 5 years ago

@0crat waiting for PR #48

0crat commented 5 years ago

@0crat waiting for PR #48 (here)

@scristalli The impediment for #45 was registered successfully by @scristalli/z

scristalli commented 5 years ago

@olenagerasimova PR #48 has been merged. Could you please edit the task description to include the additional changes discussed and made in the PR? Then I think that we can close this.

olenagerasimova commented 5 years ago

@scristalli thanks

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @scristalli/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

The job #45 is now out of scope

ammaratef45 commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z

0crat commented 5 years ago

Order was finished, quality is "good": +35 point(s) just awarded to @scristalli/z