search

g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

(#45) Refactoring fields in TkNotifications and TkThread #48

Closed scristalli closed 5 years ago

scristalli commented 5 years ago

This is for #45.

As requested in the issue, I'm changing the classes TkNotifications and TkThread so that they have a Users field instead of DataSource. I also had to change their use in BotApp to match the new constructors: the PgUsers object is now created in BotApp.

0crat commented 5 years ago

Job #48 is now in scope, role is REV

0crat commented 5 years ago

This pull request #48 is assigned to @olenagerasimova/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

scristalli commented 5 years ago

@olenagerasimova I've made changes according to your requests

olenagerasimova commented 5 years ago

@scristalli thanks

olenagerasimova commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@olenagerasimova Thanks for your request. @g4s8 Please confirm this.

g4s8 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 2min)

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

The job #48 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

ammaratef45 commented 5 years ago

@olenagerasimova

The code reviewer found at least three problems in the code

Please confirm that you will try to find at least three problems next time

olenagerasimova commented 5 years ago

@ammaratef45 I confirm

ammaratef45 commented 5 years ago

@olenagerasimova Thanks

ammaratef45 commented 5 years ago

@0crat quality acceptable

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z

0crat commented 5 years ago

Order was finished, quality is "acceptable": +15 point(s) just awarded to @olenagerasimova/z