g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

EnvironmentVariables should be renamed Configuration #60

Open victornoel opened 5 years ago

victornoel commented 5 years ago

The class EnvironmentVariables should be named Configuration or AppArguments or something like that and have two different implementation:

0crat commented 5 years ago

@g4s8/z please, pay attention to this issue

g4s8 commented 5 years ago

@victornoel I'd also try to fallback to system properties if env-variable was not found, it may be helpful for unit/integration testing, we can specify some configuration in failsafe plugin declaration and Configuration class will automatically catch these values

0crat commented 5 years ago

Job #60 is now in scope, role is DEV

victornoel commented 5 years ago

@g4s8 also there is another class named App.Options that seems to also duplicate the functionality. I think all of this could end up with one interface and multiple implementations, something like:

Configuration conf = new Chained(
  new ArgsConfiguration(args),
  new EnvConfiguration(),
  new SystemPropsConfiguration(),
  new DefaultsConfiguration("OPT1", "val1", "OPT2", "val2")
);
0crat commented 5 years ago

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

0crat commented 5 years ago

The job #60 assigned to @scristalli/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

0crat commented 5 years ago

@scristalli/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

scristalli commented 5 years ago

@0crat resign

0crat commented 5 years ago

@0crat resign (here)

@scristalli The user @scristalli/z resigned from #60, please stop working. Reason for job resignation: Order was cancelled

0crat commented 5 years ago

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @scristalli/z

0crat commented 4 years ago

The job #60 assigned to @olenagerasimova/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

0crat commented 4 years ago

@olenagerasimova/z this job was assigned to you 6days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

olenagerasimova commented 4 years ago

@0crat refuse

0crat commented 4 years ago

@0crat refuse (here)

@olenagerasimova The user @olenagerasimova/z resigned from #60, please stop working. Reason for job resignation: Order was cancelled

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat commented 4 years ago

@g4s8/z everybody who has role DEV is banned at #60; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)