search

g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

#53 UserDetails abstraction #72

Closed olenagerasimova closed 5 years ago

olenagerasimova commented 5 years ago

Created UserDetails abstraction for #53

0crat commented 5 years ago

Job #72 is now in scope, role is REV

0crat commented 5 years ago

This pull request #72 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

0crat commented 5 years ago

@victornoel/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

victornoel commented 5 years ago

@g4s8 let's reject this PR: I think we should not do the job of the @todo but just remove it. @olenagerasimova Please make another PR where you only remove the @todo so that we can finish with this.

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Code review was too long (61 days), architects (@g4s8) were penalized, see §55

0crat commented 5 years ago

The job #72 is now out of scope

0crat commented 5 years ago

Pull request #72 was not merged, no payment for ARC, see §28

ammaratef45 commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z

0crat commented 5 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @victornoel/z