Closed victornoel closed 5 years ago
This pull request #76 is assigned to @olenagerasimova/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job
@olenagerasimova thanks, see the new commits (I had to force push to fix the commit messages for gitlint, see #65)
@victornoel thanks
@rultor merge
@rultor merge
@olenagerasimova Thanks for your request. @g4s8 Please confirm this.
@g4s8 ping
@rultor merge
@rultor merge
@g4s8 OK, I'll try to merge now. You can check the progress of the merge here
Code review was too long (11 days), architects (@g4s8) were penalized, see §55
@0crat quality good
This is for #31.
I had to rework a bit the various fake implementations in order to write the test.