g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

UnreadThreadsSync test #76

Closed victornoel closed 5 years ago

victornoel commented 5 years ago

This is for #31.

I had to rework a bit the various fake implementations in order to write the test.

0crat commented 5 years ago

Job #76 is now in scope, role is REV

0crat commented 5 years ago

This pull request #76 is assigned to @olenagerasimova/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

victornoel commented 5 years ago

@olenagerasimova thanks, see the new commits (I had to force push to fix the commit messages for gitlint, see #65)

olenagerasimova commented 5 years ago

@victornoel thanks

olenagerasimova commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@olenagerasimova Thanks for your request. @g4s8 Please confirm this.

0crat commented 5 years ago

@olenagerasimova/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

olenagerasimova commented 5 years ago

@g4s8 ping

g4s8 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 3min)

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Code review was too long (11 days), architects (@g4s8) were penalized, see §55

0crat commented 5 years ago

The job #76 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

ammaratef45 commented 5 years ago

@0crat quality good

0crat commented 5 years ago

Order was finished, quality is "good": +20 point(s) just awarded to @olenagerasimova/z

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z