search

g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

(#42) - More OO loggers #80

Closed victornoel closed 5 years ago

victornoel commented 5 years ago

This is for #42.

0crat commented 5 years ago

Job #80 is now in scope, role is REV

0crat commented 5 years ago

This pull request #80 is assigned to @olenagerasimova/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

victornoel commented 5 years ago

@olenagerasimova I've pushed a new commit (and force-push/rebased because of gitlint)

olenagerasimova commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@olenagerasimova Thanks for your request. @g4s8 Please confirm this.

0crat commented 5 years ago

@olenagerasimova/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

g4s8 commented 5 years ago

@rultor merge

g4s8 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 3min)

rultor commented 5 years ago

@rultor merge

@g4s8 @victornoel The pull request is closed already, so I can't merge it

rultor commented 5 years ago

@rultor merge

@g4s8 I'm sorry, I don't understand you :( Check this page and try again please

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Code review was too long (9 days), architects (@g4s8) were penalized, see §55

0crat commented 5 years ago

The job #80 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

ammaratef45 commented 5 years ago

@olenagerasimova You found less than three problems in the PR, please confirm you will try to find at least three problems next time

olenagerasimova commented 5 years ago

@ammaratef45 I confirm

ammaratef45 commented 5 years ago

@olenagerasimova thanks

ammaratef45 commented 5 years ago

@0crat quality acceptable

0crat commented 5 years ago

Order was finished, quality is "acceptable": +15 point(s) just awarded to @olenagerasimova/z

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z