search

g4s8 / ghman

GitHub notifications Telegram bot manager
https://t.me/ghman_bot
Other
7 stars 4 forks source link

#55 - Removed Integer.parseInt, made code more readable #85

Closed scristalli closed 5 years ago

scristalli commented 5 years ago

This is for #55.

  1. I removed Integer.parseInt as requested and replaced with NumberOf. There was another occurrence of this static method in ThreadIssue.java, since even a 30 minutes puzzle seemed too much for it I've taken the liberty of replacing the method there as well.

  2. I did not find a way to reduce coupling in the construction of Issue.Smart, I think that some of the necessary improvements for doing that belong in jcabi and we don't have much room in ghman only. For the moment, I just made the code more readable by separating some declarations from the constructor call (I used TkNotifications as an example for the user).

0crat commented 5 years ago

Job #85 is now in scope, role is REV

0crat commented 5 years ago

This pull request #85 is assigned to @olenagerasimova/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

olenagerasimova commented 5 years ago

@scristalli @g4s8 no comments

olenagerasimova commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@olenagerasimova Thanks for your request. @g4s8 Please confirm this.

g4s8 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 3min)

0crat commented 5 years ago

Job #85 is not in the agenda of @olenagerasimova/z, can't inspect

0crat commented 5 years ago

@ammaratef45/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

The job #85 is now out of scope

ammaratef45 commented 5 years ago

@0crat quality bad

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

0crat commented 5 years ago

Quality is low, no payment, see §31

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @ammaratef45/z