g4v4g4i / ArgABM

An agent-based model for scientific inquiry based on abstract argumentation
10 stars 4 forks source link

`myscientists-pluralist` not updated correctly at end of run #41

Closed daimpi closed 7 years ago

daimpi commented 7 years ago

The start-owned variable myscientists-pluralist will in general not be updated correctly at the end of the run when researchers can jump one final time. The effects on the cumulative counter research-time-pluralist and it's dependent reporters (research-time "pluralist" , in-run-performance "pluralist") will be rather small as this divergence can potentially only account for up to something like 1/100 of the counter even in the most extreme cases. On the other hand the myscientists-pluralist variable itself and its reporter run-end-scientists "pluralist" should be seen as potentially incorrect in most cases, when looking at the data collected at the end of a run where the final-commands procedure was run.

The technical reason for this behavior is: myscientists-pluralist gets only updated on ticks mod 5 = 4. A fix would be to hand over an additional parameter to the compute-popularity procedure which signals it to update, b/c we're at the end of a run.