search

g7 / sailfishx-patcher-f5321

Patcher script that applies the f5321 (Xperia X Compact) compatibility layer on top of official Sailfish X f5121 images
29 stars 5 forks source link

optionally disable now-forced home encryption #17

Closed teleshoes closed 4 years ago

teleshoes commented 4 years ago

SFOS 3.4 made this buggy 5-digit "security" feature mandatory! :( :( :( honestly youre lucky to be out of this mess...

feel free to never merge this, or perhaps to comment it out by default, but i imagine the sort of people that rely on this repo probably dont like having important config options removed, and its easy to encrypt in settings afterwards.

i tested the patch on 3.4 and 3.3, and tried re-encrypting afterward on 3.4 in settings, and everything seems to work.

(oh and if you do see this, thanks again for all the great support all this time)

g7 commented 4 years ago

Hey!

thanks to you for taking the time for this pull request (and for testing 3.4 image build).

While I agree that as things stand the current encryption stuff is pretty bogus (since well, once you get the LUKS header it would be dead easy to brute force it even without having access to the device, unless you have abnormally long pin codes), having it disabled-by-default would make it diverge a bit from the behaviour of the official devices.

Do you mind making it default to "no"? I will add a paragraph on the README to explain how to disable home encryption.

Thanks!

teleshoes commented 4 years ago

(exactly! anyway...) fair enough. done, thanks!

g7 commented 4 years ago

Thank you very much, merged!

I made the patcher script source the config.sh file (see: https://github.com/g7/sailfishx-patcher-f5321/commit/51697b0e7fb296bd77df6f54d4a05d5fccfe0ada), so you can set your preferred value there without having to edit patch.sh every time.