search

g787543 / infinite-react-carousel

Infinite carousel for react
https://g787543.github.io/infinite-react-carousel/
MIT License
110 stars 34 forks source link

Needs ForEach Polyfill #14

Closed clayo closed 4 years ago

clayo commented 4 years ago

Does not support IE 11, get the error message "Object doesn't support property or method 'forEach'". Adding react-app-polyfill and other polyfill offerings to project do not help... the issues is inside the carousel libraries where the polyfill libraries are not being imported.

Looks like this is specific to SPfx (SharePoint Framework) webparts. The carousel works when standing on it's own, but put it into a SharePoint Framework webpart and the forEach calls all blow up internally to the infinite-react-carousel node_module.

g787543 commented 4 years ago

Hi @clayo,

What is your package version?

clayo commented 4 years ago

Whatever the latest is. Did an npm install on it yesterday.

Sent from my iPhone

Clay Osborn Software Development Team Lead direct 616-233-4554 | office (248) 412-8200 email cosborn@redlevelgroup.com | web redlevelgroup.com Modern Workplace Webinar

On Feb 18, 2020, at 7:20 PM, Hans notifications@github.com wrote:



Hi @clayohttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclayo&data=02%7C01%7Ccosborn%40redlevelgroup.com%7C3c7e6c0b0a784f019f4808d7b4d1678a%7Cac56cd7ed609407a9eb4c77b623198f3%7C0%7C0%7C637176684243823322&sdata=3VYuHL8UVzvYgC%2B78TKcpZzNcfyY%2BQIfbIPrMt8X3TQ%3D&reserved=0,

What is your package version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fg787543%2Finfinite-react-carousel%2Fissues%2F14%3Femail_source%3Dnotifications%26email_token%3DADGU43SSLNXNJ6FKFOL6KSTRDR3JRA5CNFSM4KXIS2KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMF3R6A%23issuecomment-587970808&data=02%7C01%7Ccosborn%40redlevelgroup.com%7C3c7e6c0b0a784f019f4808d7b4d1678a%7Cac56cd7ed609407a9eb4c77b623198f3%7C0%7C0%7C637176684243823322&sdata=nan6E4aAiLB2c4uPKw66wHa8Q5P6EtdohQp3%2Fk%2BLEis%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADGU43SKGD66WMMRC4O77XLRDR3JRANCNFSM4KXIS2KA&data=02%7C01%7Ccosborn%40redlevelgroup.com%7C3c7e6c0b0a784f019f4808d7b4d1678a%7Cac56cd7ed609407a9eb4c77b623198f3%7C0%7C0%7C637176684243833320&sdata=kphQJ3n3A4sZqm1cGuc0jiscV6gvGmlhK4Mh4K0Km0w%3D&reserved=0.

g787543 commented 4 years ago

Ok, I remove all of forEach. I will release later

g787543 commented 4 years ago

I already release the new version on npm, please try again, Thanks.

clayo commented 4 years ago

That did the trick!! That was some awesome response time. Thank you!